MS custom idp & more custom execution steps #29
Conversation
src/main/java/tech/neon/custom/NeonCleanUnverifiedAuthenticator.java
Outdated
Show resolved
Hide resolved
src/main/java/tech/neon/custom/NeonIdpEmailVerifyAuthenticator.java
Outdated
Show resolved
Hide resolved
src/main/java/tech/neon/custom/NeonIdpEmailVerifyAuthenticator.java
Outdated
Show resolved
Hide resolved
src/main/java/tech/neon/microsoft/MicrosoftUserAttributeMapper.java
Outdated
Show resolved
Hide resolved
|
|
||
| import org.keycloak.broker.oidc.mappers.UserAttributeMapper; | ||
|
|
||
| public class MicrosoftUserAttributeMapper extends UserAttributeMapper { |
There was a problem hiding this comment.
Since your MicrosoftIdentityProvider extends OIDCIdentityProvider, the builtin UserAttributeMapper might already be selectable for it, I think?
There was a problem hiding this comment.
builtin UserAttributeMapper returns hardcoded COMPATIBLE_PROVIDERS in getCompatibleProviders. This subclass is just overrides this method.
There was a problem hiding this comment.
Right. I'm saying that UserAttributeMapper includes OIDCIdentityProviderFactory.PROVIDER_ID in the compatible providers, and since your provider extends OIDCIdentityProvider I think the builtin mapper should already treat it as compatible.
There was a problem hiding this comment.
If not, then it's fine to extend it.
There was a problem hiding this comment.
Hmm. I don't think it takes into account parent classes. I think it failed when I tried, but I will try one more time.
…r.java Co-authored-by: Krzysztof Szafrański <[email protected]>
Co-authored-by: Krzysztof Szafrański <[email protected]>
….java Co-authored-by: Krzysztof Szafrański <[email protected]>
….java Co-authored-by: Krzysztof Szafrański <[email protected]>
Co-authored-by: Krzysztof Szafrański <[email protected]>
….java Co-authored-by: Krzysztof Szafrański <[email protected]>
No description provided.