-
Notifications
You must be signed in to change notification settings - Fork 461
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(compute): Report compute_backpressure_throttling_seconds as count…
…er (#10125) ## Problem It was reported as `gauge`, but it's actually a `counter`. Also add `_total` suffix as that's the convention for counters. The corresponding flux-fleet PR: neondatabase/flux-fleet#386
- Loading branch information
Showing
3 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
...backpressure_throttling_seconds.libsonnet → ...essure_throttling_seconds_total.libsonnet
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
{ | ||
metric_name: 'compute_backpressure_throttling_seconds', | ||
type: 'gauge', | ||
metric_name: 'compute_backpressure_throttling_seconds_total', | ||
type: 'counter', | ||
help: 'Time compute has spent throttled', | ||
key_labels: null, | ||
values: [ | ||
'throttled', | ||
], | ||
query: importstr 'sql_exporter/compute_backpressure_throttling_seconds.sql', | ||
query: importstr 'sql_exporter/compute_backpressure_throttling_seconds_total.sql', | ||
} |
File renamed without changes.
2dfd3ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7245 tests run: 6937 passed, 1 failed, 307 skipped (full report)
Failures on Postgres 16
test_storage_controller_many_tenants[github-actions-selfhosted]
: release-x86-64Flaky tests (5)
Postgres 17
test_physical_replication_config_mismatch_too_many_known_xids
: release-arm64Postgres 16
test_pgdata_import_smoke[None-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]
: release-arm64test_pgdata_import_smoke[8-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]
: release-arm64Postgres 15
test_pgdata_import_smoke[None-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]
: release-arm64Postgres 14
test_tenant_redownloads_truncated_file_on_startup
: release-arm64Code coverage* (full report)
functions
:31.3% (8395 of 26788 functions)
lines
:48.0% (66610 of 138664 lines)
* collected from Rust tests only
2dfd3ca at 2024-12-17T18:27:35.382Z :recycle: