Skip to content

Commit

Permalink
fix(pageserver): increase frozen layer warning threshold; ignore in t…
Browse files Browse the repository at this point in the history
…ests (#9705)

Perf benchmarks produce a lot of layers.

## Summary of changes

Bumping the threshold and ignore the warning.

---------

Signed-off-by: Alex Chi Z <[email protected]>
  • Loading branch information
skyzh authored Nov 11, 2024
1 parent f510647 commit 48c06d9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pageserver/src/tenant/timeline.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3531,7 +3531,7 @@ impl Timeline {
self.get_compaction_threshold(),
DEFAULT_COMPACTION_THRESHOLD,
)
&& frozen_layer_total_size >= /* 64 MB */ 64000000
&& frozen_layer_total_size >= /* 128 MB */ 128000000
{
tracing::warn!(
"too many frozen layers: {num_frozen_layers} layers with estimated in-mem size of {frozen_layer_total_size} bytes",
Expand Down
2 changes: 2 additions & 0 deletions test_runner/fixtures/pageserver/allowed_errors.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ def scan_pageserver_log_for_errors(
".*WARN.*path=/v1/utilization .*request was dropped before completing",
# Can happen during shutdown
".*scheduling deletion on drop failed: queue is in state Stopped.*",
# Too many frozen layers error is normal during intensive benchmarks
".*too many frozen layers.*",
)


Expand Down

1 comment on commit 48c06d9

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5355 tests run: 5132 passed, 1 failed, 222 skipped (full report)


Failures on Postgres 15

  • test_metrics_while_ignoring_broken_tenant_and_reloading: release-arm64
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_metrics_while_ignoring_broken_tenant_and_reloading[release-pg15]"

Test coverage report is not available

The comment gets automatically updated with the latest test results
48c06d9 at 2024-11-11T15:04:55.016Z :recycle:

Please sign in to comment.