Skip to content

Commit

Permalink
pagebench: fix percentiles reporting (#6547)
Browse files Browse the repository at this point in the history
Before this patch, pagebench was always showing the same value.

refs #6509
  • Loading branch information
problame authored Jan 31, 2024
1 parent e82625b commit 4c17345
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions pageserver/pagebench/src/util/request_stats.rs
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,10 @@ impl serde::Serialize for LatencyPercentiles {
{
use serde::ser::SerializeMap;
let mut ser = serializer.serialize_map(Some(LATENCY_PERCENTILES.len()))?;
for p in LATENCY_PERCENTILES {
for (p, v) in LATENCY_PERCENTILES.iter().zip(&self.latency_percentiles) {
ser.serialize_entry(
&format!("p{p}"),
&format!(
"{}",
&humantime::format_duration(self.latency_percentiles[0])
),
&format!("{}", humantime::format_duration(*v)),
)?;
}
ser.end()
Expand Down

1 comment on commit 4c17345

@github-actions
Copy link

@github-actions github-actions bot commented on 4c17345 Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2450 tests run: 2329 passed, 0 failed, 121 skipped (full report)


Flaky tests (7)

Postgres 16

Postgres 15

Postgres 14

Code coverage (full report)

  • functions: 54.4% (11206 of 20582 functions)
  • lines: 81.5% (63125 of 77469 lines)

The comment gets automatically updated with the latest test results
4c17345 at 2024-02-01T11:21:41.782Z :recycle:

Please sign in to comment.