Skip to content

Commit

Permalink
Fix compiler warnings on macOS (#9128)
Browse files Browse the repository at this point in the history
## Problem

Compilation of neon extension on macOS produces a warning
```
pgxn/neon/neon_perf_counters.c:50:1: error: non-void function does not return a value [-Werror,-Wreturn-type]
```

## Summary of changes
- Change the return type of `NeonPerfCountersShmemInit` to void
  • Loading branch information
bayandin authored Sep 24, 2024
1 parent c47f355 commit 523cf71
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pgxn/neon/neon_perf_counters.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ NeonPerfCountersShmemSize(void)
return size;
}

bool
void
NeonPerfCountersShmemInit(void)
{
bool found;
Expand Down
2 changes: 1 addition & 1 deletion pgxn/neon/neon_perf_counters.h
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ extern neon_per_backend_counters *neon_per_backend_counters_shared;
extern void inc_getpage_wait(uint64 latency);

extern Size NeonPerfCountersShmemSize(void);
extern bool NeonPerfCountersShmemInit(void);
extern void NeonPerfCountersShmemInit(void);


#endif /* NEON_PERF_COUNTERS_H */

1 comment on commit 523cf71

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5074 tests run: 4898 passed, 2 failed, 174 skipped (full report)


Failures on Postgres 16

  • test_gc_feedback_with_snapshots[github-actions-selfhosted]: release-x86-64
  • test_compaction_l0_memory[github-actions-selfhosted]: release-x86-64
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_gc_feedback_with_snapshots[release-pg16-github-actions-selfhosted] or test_compaction_l0_memory[release-pg16-github-actions-selfhosted]"
Flaky tests (7)

Postgres 17

Postgres 16

Postgres 15

Code coverage* (full report)

  • functions: 32.2% (7477 of 23255 functions)
  • lines: 50.0% (60233 of 120574 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
523cf71 at 2024-09-24T20:40:29.895Z :recycle:

Please sign in to comment.