feat(pageserver): use json for timeline metadata encoding

Signed-off-by: Alex Chi Z <[email protected]>
neondatabase · May 8, 2024 · 5418e80 · 5418e80
1 parent ca154d9
commit 5418e80
Show file tree

Hide file tree

Showing 3 changed files with 172 additions and 148 deletions.
diff --git a/libs/postgres_ffi/src/lib.rs b/libs/postgres_ffi/src/lib.rs
@@ -157,7 +157,9 @@ pub fn generate_wal_segment(
     dispatch_pgversion!(
         pg_version,
         pgv::xlog_utils::generate_wal_segment(segno, system_id, lsn),
-        Err(SerializeError::BadInput)
+        Err(SerializeError::BadInput(anyhow::anyhow!(
+            "failed to generate wal segment"
+        )))
     )
 }
 

diff --git a/libs/utils/src/bin_ser.rs b/libs/utils/src/bin_ser.rs
@@ -48,8 +48,8 @@ impl From<bincode::Error> for DeserializeError {
 #[derive(Debug, Error)]
 pub enum SerializeError {
     /// The serializer isn't able to serialize the supplied data.
-    #[error("serialize error")]
-    BadInput,
+    #[error("serialize error: {0}")]
+    BadInput(anyhow::Error),
     /// While serializing into a `Write` sink, an `io::Error` occurred.
     #[error("serialize error: {0}")]
     Io(io::Error),
@@ -59,7 +59,7 @@ impl From<bincode::Error> for SerializeError {
     fn from(e: bincode::Error) -> Self {
         match *e {
             bincode::ErrorKind::Io(io_err) => SerializeError::Io(io_err),
-            _ => SerializeError::BadInput,
+            err => SerializeError::BadInput(err.into()),
         }
     }
 }