Skip to content

Commit

Permalink
CI(deploy): fix git tag/release creation (#10119)
Browse files Browse the repository at this point in the history
## Problem

When moving the comment on proxy-releases from the yaml doc into a
javascript code block, I missed converting the comment marker from `#`
to `//`.

## Summary of changes

Correctly convert comment marker.
  • Loading branch information
jcgruenhage authored Dec 12, 2024
1 parent ac04bad commit 59ef701
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1143,7 +1143,7 @@ jobs:
console.log(`Tag ${tag} created successfully.`);
}
# TODO: check how GitHub releases looks for proxy/compute releases and enable them if they're ok
// TODO: check how GitHub releases looks for proxy/compute releases and enable them if they're ok
if (context.ref !== 'refs/heads/release') {
console.log(`GitHub release skipped for ${context.ref}.`);
return;
Expand Down

1 comment on commit 59ef701

@github-actions
Copy link

@github-actions github-actions bot commented on 59ef701 Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7121 tests run: 6824 passed, 0 failed, 297 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 14

  • test_pgdata_import_smoke[None-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64

Code coverage* (full report)

  • functions: 31.4% (8403 of 26732 functions)
  • lines: 48.1% (66643 of 138650 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
59ef701 at 2024-12-13T01:41:38.640Z :recycle:

Please sign in to comment.