Skip to content

Commit

Permalink
fix(test): drop subscription when test completes (#6975)
Browse files Browse the repository at this point in the history
This pull request mitigates
#6969, but the longer-term
problem is that we cannot properly stop Postgres if there is a
subscription.

---------

Signed-off-by: Alex Chi Z <[email protected]>
  • Loading branch information
skyzh authored Mar 6, 2024
1 parent 4a31e18 commit 5dc2088
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test_runner/regress/test_neon_superuser.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
from fixtures.log_helper import log
from fixtures.neon_fixtures import NeonEnv
from fixtures.pg_version import PgVersion, skip_on_postgres
from fixtures.pg_version import PgVersion
from fixtures.utils import wait_until


@skip_on_postgres(
PgVersion.V15, reason="skip on pg15 due to https://github.com/neondatabase/neon/issues/6969"
)
def test_neon_superuser(neon_simple_env: NeonEnv, pg_version: PgVersion):
env = neon_simple_env
env.neon_cli.create_branch("test_neon_superuser_publisher", "empty")
Expand Down Expand Up @@ -97,3 +94,6 @@ def check_that_changes_propagated():
assert cur.fetchall()[0][0] != "<insufficient privilege>"
cur.execute("RESET ROLE")
cur.execute("DROP ROLE not_a_superuser")
query = "DROP SUBSCRIPTION sub CASCADE"
log.info(f"Dropping subscription: {query}")
cur.execute(query)

1 comment on commit 5dc2088

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2567 tests run: 2433 passed, 0 failed, 134 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_timeline_size_quota_on_startup: release

Code coverage* (full report)

  • functions: 28.8% (6992 of 24258 functions)
  • lines: 47.4% (43009 of 90698 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
5dc2088 at 2024-03-06T16:43:53.825Z :recycle:

Please sign in to comment.