Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Optimize storing of null page in WAL (#5910)
## Problem PG16 (neondatabase/postgres#327) adds new function to SMGR: zeroextend It's implementation in Neon actually wal-log zero pages of extended relation. This zero page is wal-logged using XLOG_FPI. As far as page is zero, the hole optimization (excluding from the image everything between pg_upper and pd_lower) doesn't work. ## Summary of changes In case of zero page (`PageIsNull()` returns true) assume `hole_size=BLCKSZ` ## Checklist before requesting a review - [ ] I have performed a self-review of my code. - [ ] If it is a core feature, I have added thorough tests. - [ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard? - [ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section. ## Checklist before merging - [ ] Do not forget to reformat commit message to not include the above checklist --------- Co-authored-by: Konstantin Knizhnik <[email protected]>
- Loading branch information
6489059
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2468 tests run: 2367 passed, 0 failed, 101 skipped (full report)
Flaky tests (3)
Postgres 16
test_branching_with_pgbench[cascade-1-10]
: debugPostgres 15
test_restarts_frequent_checkpoints
: releasePostgres 14
test_timeline_deletion_with_files_stuck_in_upload_queue
: debugCode coverage (full report)
functions
:54.3% (9159 of 16854 functions)
lines
:82.1% (53440 of 65129 lines)
6489059 at 2023-11-29T11:13:30.284Z :recycle: