Skip to content

Commit

Permalink
Enable compatibility tests on Postgres 16 (#5314)
Browse files Browse the repository at this point in the history
## Problem

We didn't have a Postgres 16 snapshot of data to run compatibility tests
on, but now we have it (since the release).

## Summary of changes
- remove `@skip_on_postgres(PgVersion.V16, ...)` from compatibility
tests
  • Loading branch information
bayandin authored Sep 18, 2023
1 parent 0904d8c commit 70b1798
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions test_runner/regress/test_compatibility.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
wait_for_last_record_lsn,
wait_for_upload,
)
from fixtures.pg_version import PgVersion, skip_on_postgres
from fixtures.pg_version import PgVersion
from fixtures.port_distributor import PortDistributor
from fixtures.remote_storage import LocalFsStorage, RemoteStorageKind, RemoteStorageUser
from fixtures.types import Lsn
Expand Down Expand Up @@ -151,7 +151,6 @@ def test_create_snapshot(
shutil.copytree(test_output_dir, compatibility_snapshot_dir)


@skip_on_postgres(PgVersion.V16, reason="TODO: Enable after the first Postgres 16 release")
@check_ondisk_data_compatibility_if_enabled
@pytest.mark.xdist_group("compatibility")
@pytest.mark.order(after="test_create_snapshot")
Expand Down Expand Up @@ -209,7 +208,6 @@ def test_backward_compatibility(
), "Breaking changes are allowed by ALLOW_BACKWARD_COMPATIBILITY_BREAKAGE, but the test has passed without any breakage"


@skip_on_postgres(PgVersion.V16, reason="TODO: Enable after the first Postgres 16 release")
@check_ondisk_data_compatibility_if_enabled
@pytest.mark.xdist_group("compatibility")
@pytest.mark.order(after="test_create_snapshot")
Expand Down

1 comment on commit 70b1798

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2552 tests run: 2428 passed, 0 failed, 124 skipped (full report)


Flaky tests (2)

Postgres 16

  • test_partial_evict_tenant: debug
  • test_wal_lagging: release

Code coverage (full report)

  • functions: 53.0% (7753 of 14615 functions)
  • lines: 81.0% (45246 of 55832 lines)

The comment gets automatically updated with the latest test results
70b1798 at 2023-09-18T12:42:34.731Z :recycle:

Please sign in to comment.