Skip to content

Commit

Permalink
tests: adjust threshold in test_partial_evict_tenant (#8509)
Browse files Browse the repository at this point in the history
## Problem

This test was destabilized by
#8431. The threshold is
arbitrary & failures are still quite close to it. At a high level the
test is asserting "eviction was approximately fair to these tenants",
which appears to still be the case when the abs diff between ratios is
slightly higher at ~0.6-0.7.

## Summary of changes

- Change threshold from 0.06 to 0.065. Based on the last ~10 failures
that should be sufficient.
  • Loading branch information
jcsp authored Jul 25, 2024
1 parent 24ea9f9 commit 775c0c8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test_runner/regress/test_disk_usage_eviction.py
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ def test_partial_evict_tenant(eviction_env: EvictionEnv, order: EvictionOrder):
abs_diff = abs(ratio - expected_ratio)
assert original_count > count_now

expectation = 0.06
expectation = 0.065
log.info(
f"tenant {tenant_id} layer count {original_count} -> {count_now}, ratio: {ratio}, expecting {abs_diff} < {expectation}"
)
Expand Down

1 comment on commit 775c0c8

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3132 tests run: 3009 passed, 2 failed, 121 skipped (full report)


Failures on Postgres 15

  • test_slow_secondary_downloads[True]: release

Failures on Postgres 14

  • test_pageserver_lsn_wait_error_safekeeper_stop: debug
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_pageserver_lsn_wait_error_safekeeper_stop[debug-pg14] or test_slow_secondary_downloads[release-pg15-True]"
Flaky tests (1)

Postgres 14

  • test_sharding_split_compaction[compact-shard-ancestors-localonly]: debug

Test coverage report is not available

The comment gets automatically updated with the latest test results
775c0c8 at 2024-07-25T14:45:01.046Z :recycle:

Please sign in to comment.