Skip to content

Commit

Permalink
chore: Silence clippy warning with nightly (#9157)
Browse files Browse the repository at this point in the history
The warning:

    warning: first doc comment paragraph is too long
      --> pageserver/src/tenant/checks.rs:7:1
       |
7 | / /// Checks whether a layer map is valid (i.e., is a valid result
of the current compaction algorithm if no...
8 | | /// The function checks if we can split the LSN range of a delta
layer only at the LSNs of the delta layer...
    9  | | ///
    10 | | /// ```plain
       | |_
       |
= help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
= note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
    help: add an empty line
       |
7 ~ /// Checks whether a layer map is valid (i.e., is a valid result of
the current compaction algorithm if nothing goes wrong).
    8  + ///
       |

Fix by applying the suggestion.
  • Loading branch information
hlinnaka authored Sep 25, 2024
1 parent 684e924 commit 7e560dd
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pageserver/src/tenant/checks.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ use itertools::Itertools;
use super::storage_layer::LayerName;

/// Checks whether a layer map is valid (i.e., is a valid result of the current compaction algorithm if nothing goes wrong).
///
/// The function checks if we can split the LSN range of a delta layer only at the LSNs of the delta layers. For example,
///
/// ```plain
Expand Down

1 comment on commit 7e560dd

@github-actions
Copy link

@github-actions github-actions bot commented on 7e560dd Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5101 tests run: 4926 passed, 1 failed, 174 skipped (full report)


Failures on Postgres 16

  • test_gc_feedback_with_snapshots[github-actions-selfhosted]: release-x86-64
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_gc_feedback_with_snapshots[release-pg16-github-actions-selfhosted]"
Flaky tests (3)

Postgres 17

Postgres 16

Code coverage* (full report)

  • functions: 32.0% (7490 of 23396 functions)
  • lines: 50.0% (60465 of 120856 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
7e560dd at 2024-09-25T23:58:52.837Z :recycle:

Please sign in to comment.