Skip to content

Commit

Permalink
walreceiver-after-ingest failpoint: use pausable_failpoint
Browse files Browse the repository at this point in the history
Possibly the last commit was a red herring (still a good cleanup though).

However, this one here is a definite executor stall at the failpoint.

And it makes sense that it would cause the shutdown timeouts with the
unified runtime, because the walreceiver code previously ran on a
separate runtime.
  • Loading branch information
problame committed Mar 23, 2024
1 parent a784f4c commit 945f3b5
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ use std::{
use anyhow::{anyhow, Context};
use bytes::BytesMut;
use chrono::{NaiveDateTime, Utc};
use fail::fail_point;
use futures::StreamExt;
use postgres::{error::SqlState, SimpleQueryMessage, SimpleQueryRow};
use postgres_ffi::WAL_SEGMENT_SIZE;
Expand Down Expand Up @@ -326,7 +325,7 @@ pub(super) async fn handle_walreceiver_connection(
filtered_records += 1;
}

fail_point!("walreceiver-after-ingest");
pausable_failpoint!("walreceiver-after-ingest");

last_rec_lsn = lsn;

Expand Down

0 comments on commit 945f3b5

Please sign in to comment.