Skip to content

Commit

Permalink
tests: increase test_pg_regress and test_isolation timeouts (#8418)
Browse files Browse the repository at this point in the history
## Problem

These tests time out ~1 in 50 runs when in debug mode.

There is no indication of a real issue: they're just wrappers that have
large numbers of individual tests contained within on pytest case.

## Summary of changes

- Bump pg_regress timeout from 600 to 900s
- Bump test_isolation timeout from 300s (default) to 600s

In future it would be nice to break out these tests to run individual
cases (or batches thereof) as separate tests, rather than this monolith.
  • Loading branch information
jcsp authored Jul 18, 2024
1 parent 7672e49 commit 9ded255
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test_runner/regress/test_pg_regress.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def post_checks(env: NeonEnv, test_output_dir: Path, db_name: str, endpoint: End

# Run the main PostgreSQL regression tests, in src/test/regress.
#
@pytest.mark.timeout(600)
@pytest.mark.timeout(900) # Contains many sub-tests, is slow in debug builds
@pytest.mark.parametrize("shard_count", [None, 4])
def test_pg_regress(
neon_env_builder: NeonEnvBuilder,
Expand Down Expand Up @@ -186,6 +186,7 @@ def test_pg_regress(

# Run the PostgreSQL "isolation" tests, in src/test/isolation.
#
@pytest.mark.timeout(600) # Contains many sub-tests, is slow in debug builds
@pytest.mark.parametrize("shard_count", [None, 4])
def test_isolation(
neon_env_builder: NeonEnvBuilder,
Expand Down

1 comment on commit 9ded255

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3202 tests run: 3068 passed, 1 failed, 133 skipped (full report)


Failures on Postgres 14

  • test_slow_secondary_downloads[False]: release
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_slow_secondary_downloads[release-pg14-False]"

Test coverage report is not available

The comment gets automatically updated with the latest test results
9ded255 at 2024-07-18T10:54:23.816Z :recycle:

Please sign in to comment.