Skip to content

Commit

Permalink
set LogicalSize::cancel_wait_for_background_loop_concurrency_limit_se…
Browse files Browse the repository at this point in the history
…maphore early

Before, walreceiver would already be running and hit the warning log
message that this patch also rectifies.
  • Loading branch information
problame committed Dec 1, 2023
1 parent 5dec9f4 commit a717bef
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pageserver/src/tenant/timeline.rs
Original file line number Diff line number Diff line change
Expand Up @@ -900,10 +900,10 @@ impl Timeline {
background_jobs_can_start: Option<&completion::Barrier>,
ctx: &RequestContext,
) {
self.spawn_initial_logical_size_computation_task(ctx);
self.launch_wal_receiver(ctx, broker_client);
self.set_state(TimelineState::Active);
self.launch_eviction_task(background_jobs_can_start);
self.spawn_initial_logical_size_computation_task(ctx);
}

/// Graceful shutdown, may do a lot of I/O as we flush any open layers to disk and then
Expand Down Expand Up @@ -1777,7 +1777,7 @@ impl Timeline {
{
Some(cancel) => cancel.cancel(),
None => {
warn!("unexpected: priority_tx not set, logical size calculation will not be prioritized");
warn!("unexpected: cancel_wait_for_background_loop_concurrency_limit_semaphore not set, priority-boosting of logical size calculation will not work");
}
};
}
Expand Down

0 comments on commit a717bef

Please sign in to comment.