Skip to content

Commit

Permalink
test_compatibility: flush in the end (#8804)
Browse files Browse the repository at this point in the history
`test_forward_compatibility` is still often failing at graceful
shutdown. Fix this by explicit flush before shutdown.

Example:
https://neon-github-public-dev.s3.amazonaws.com/reports/main/10506613738/index.html#testresult/5e7111907f7ecfb2/

Cc: #8655 and #8708
Previous attempt: #8787
  • Loading branch information
koivunej authored Aug 22, 2024
1 parent 1a9d559 commit b1c4578
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions test_runner/regress/test_compatibility.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@
import toml
from fixtures.common_types import TenantId, TimelineId
from fixtures.log_helper import log
from fixtures.neon_fixtures import NeonEnv, NeonEnvBuilder, PgBin, flush_ep_to_pageserver
from fixtures.neon_fixtures import (
NeonEnv,
NeonEnvBuilder,
PgBin,
flush_ep_to_pageserver,
)
from fixtures.pageserver.http import PageserverApiException
from fixtures.pageserver.utils import (
timeline_delete_wait_completed,
Expand Down Expand Up @@ -296,7 +301,7 @@ def check_neon_works(env: NeonEnv, test_output_dir: Path, sql_dump_path: Path, r
pg_version = env.pg_version

# Stop endpoint while we recreate timeline
ep.stop()
flush_ep_to_pageserver(env, ep, tenant_id, timeline_id)

try:
pageserver_http.timeline_preserve_initdb_archive(tenant_id, timeline_id)
Expand Down Expand Up @@ -344,6 +349,11 @@ def check_neon_works(env: NeonEnv, test_output_dir: Path, sql_dump_path: Path, r
assert not dump_from_wal_differs, "dump from WAL differs"
assert not initial_dump_differs, "initial dump differs"

flush_ep_to_pageserver(env, ep, tenant_id, timeline_id)
pageserver_http.timeline_checkpoint(
tenant_id, timeline_id, compact=False, wait_until_uploaded=True
)


def dump_differs(
first: Path, second: Path, output: Path, allowed_diffs: Optional[List[str]] = None
Expand Down

1 comment on commit b1c4578

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3889 tests run: 3772 passed, 1 failed, 116 skipped (full report)


Failures on Postgres 16

  • test_pgbench_intensive_init_workload[neon_off-github-actions-selfhosted-1000]: release
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_pgbench_intensive_init_workload[neon_off-release-pg16-github-actions-selfhosted-1000]"

Code coverage* (full report)

  • functions: 32.4% (7241 of 22342 functions)
  • lines: 50.4% (58536 of 116127 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b1c4578 at 2024-08-22T17:37:20.658Z :recycle:

Please sign in to comment.