-
Notifications
You must be signed in to change notification settings - Fork 463
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[compute_ctl] User correct HTTP code in the /configure errors (#6017)
It was using `PRECONDITION_FAILED` for errors during `ComputeSpec` to `ParsedSpec` conversion, but this disobeys the OpenAPI spec [1] and correct code should be `BAD_REQUEST` for any spec processing errors. While on it, I also noticed that `compute_ctl` OpenAPI spec has an invalid format and fixed it. [1] https://github.com/neondatabase/neon/blob/fd81945a60dff25fea65a50f2c8cd6e4c955fba4/compute_tools/src/http/openapi_spec.yaml#L119-L120
- Loading branch information
Showing
2 changed files
with
11 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1295bf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2498 tests run: 2393 passed, 2 failed, 103 skipped (full report)
Failures on Postgres 16
test_ondemand_download_timetravel[real_s3]
: debugFailures on Postgres 14
test_pgbench_intensive_init_workload[neon_off-1000]
: releaseFlaky tests (3)
Postgres 16
test_ondemand_download_timetravel[local_fs]
: debugtest_ondemand_download_timetravel[mock_s3]
: debugPostgres 14
test_branching_with_pgbench[cascade-1-10]
: debugTest coverage report is not available
c1295bf at 2023-12-01T18:03:31.939Z :recycle: