impr(pageserver): abort on fatal I/O writer error (#8777)

part of #8140 The blob writer path now uses `maybe_fatal_err` Signed-off-by: Alex Chi Z <[email protected]>
neondatabase · Aug 20, 2024 · c8b9116 · c8b9116 · github-actions · Aug 20, 2024
1 parent beefc7a
commit c8b9116
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/pageserver/src/virtual_file.rs b/pageserver/src/virtual_file.rs
@@ -756,11 +756,23 @@ impl VirtualFile {
         })
     }
 
+    /// The function aborts the process if the error is fatal.
     async fn write_at<B: IoBuf + Send>(
         &self,
         buf: FullSlice<B>,
         offset: u64,
         _ctx: &RequestContext, /* TODO: use for metrics: https://github.com/neondatabase/neon/issues/6107 */
+    ) -> (FullSlice<B>, Result<usize, Error>) {
+        let (slice, result) = self.write_at_inner(buf, offset, _ctx).await;
+        let result = result.maybe_fatal_err("write_at");
+        (slice, result)
+    }
+
+    async fn write_at_inner<B: IoBuf + Send>(
+        &self,
+        buf: FullSlice<B>,
+        offset: u64,
+        _ctx: &RequestContext, /* TODO: use for metrics: https://github.com/neondatabase/neon/issues/6107 */
     ) -> (FullSlice<B>, Result<usize, Error>) {
         let file_guard = match self.lock_file().await {
             Ok(file_guard) => file_guard,