Skip to content

Commit

Permalink
test_runner: don't create artifacts if Allure is not enabled (#8580)
Browse files Browse the repository at this point in the history
## Problem

`allure_attach_from_dir` method might create `tar.zst` archives even
if `--alluredir` is not set (i.e. Allure results collection is disabled)

## Summary of changes
- Don't run `allure_attach_from_dir` if `--alluredir`  is not set
  • Loading branch information
bayandin authored Aug 1, 2024
1 parent f4a668a commit e747785
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions test_runner/fixtures/neon_fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -4529,6 +4529,13 @@ def test_output_dir(

yield test_dir

# Allure artifacts creation might involve the creation of `.tar.zst` archives,
# which aren't going to be used if Allure results collection is not enabled
# (i.e. --alluredir is not set).
# Skip `allure_attach_from_dir` in this case
if not request.config.getoption("--alluredir"):
return

preserve_database_files = False
for k, v in request.node.user_properties:
# NB: the neon_env_builder fixture uses this fixture (test_output_dir).
Expand Down

1 comment on commit e747785

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2188 tests run: 2107 passed, 2 failed, 79 skipped (full report)


Failures on Postgres 14

  • test_gc_feedback_with_snapshots[github-actions-selfhosted]: release
  • test_gc_feedback[github-actions-selfhosted]: release
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_gc_feedback_with_snapshots[release-pg14-github-actions-selfhosted] or test_gc_feedback[release-pg14-github-actions-selfhosted]"
Flaky tests (1)

Postgres 14

Code coverage* (full report)

  • functions: 32.9% (7126 of 21683 functions)
  • lines: 50.4% (57369 of 113719 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
e747785 at 2024-08-01T19:43:46.233Z :recycle:

Please sign in to comment.