Skip to content

Commit

Permalink
Use updated patched azure SDK crates (#10036)
Browse files Browse the repository at this point in the history
For a while already, we've been unable to update the Azure SDK crates
due to Azure adopting use of a non-tokio async runtime, see #7545.

The effort to upstream the fix got stalled, and I think it's better to
switch to a patched version of the SDK that is up to date.

Now we have a fork of the SDK under the neondatabase github org, to
which I have applied Conrad's rebased patches to:
https://github.com/neondatabase/azure-sdk-for-rust/tree/neon .

The existence of a fork will also help with shipping bulk delete support
before it's upstreamed (#7931).

Also, in related news, the Azure SDK has gotten a rift in development,
where the main branch pertains to a future, to-be-officially-blessed
release of the SDK, and the older versions, which we are currently
using, are on the `legacy` branch. Upstream doesn't really want patches
for the `legacy` branch any more, they want to focus on the `main`
efforts. However, even then, the `legacy` branch is still newer than
what we are having right now, so let's switch to `legacy` for now.

Depending on how long it takes, we can switch to the official version of
the SDK once it's released or switch to the upstream `main` branch if
there is changes we want before that.

As a nice side effect of this PR, we now use reqwest 0.12 everywhere,
dropping the dependency on version 0.11.

Fixes #7545
  • Loading branch information
arpad-m authored Dec 9, 2024
1 parent 4cca5cd commit e74e7aa
Show file tree
Hide file tree
Showing 3 changed files with 47 additions and 122 deletions.
151 changes: 37 additions & 114 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

1 comment on commit e74e7aa

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7201 tests run: 6866 passed, 0 failed, 335 skipped (full report)


Flaky tests (4)

Postgres 16

Code coverage* (full report)

  • functions: 31.4% (8329 of 26528 functions)
  • lines: 47.7% (65545 of 137367 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
e74e7aa at 2024-12-09T18:47:55.128Z :recycle:

Please sign in to comment.