Skip to content

Commit

Permalink
pageserver: mention key in walredo errors (#6988)
Browse files Browse the repository at this point in the history
## Problem

- Walredo errors, e.g. during image creation, mention the LSN affected
but not the key.

## Summary of changes

- Add key to "error applying ... WAL records" log message
  • Loading branch information
jcsp authored Mar 4, 2024
1 parent 20d0939 commit fad9be4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pageserver/src/walredo.rs
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ impl PostgresRedoManager {
// next request will launch a new one.
if let Err(e) = result.as_ref() {
error!(
"error applying {} WAL records {}..{} ({} bytes) to base image with LSN {} to reconstruct page image at LSN {} n_attempts={}: {:?}",
"error applying {} WAL records {}..{} ({} bytes) to key {key}, from base image with LSN {} to reconstruct page image at LSN {} n_attempts={}: {:?}",
records.len(),
records.first().map(|p| p.0).unwrap_or(Lsn(0)),
records.last().map(|p| p.0).unwrap_or(Lsn(0)),
Expand Down

1 comment on commit fad9be4

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2561 tests run: 2428 passed, 0 failed, 133 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_crafted_wal_end[last_wal_record_crossing_segment]: debug

Code coverage* (full report)

  • functions: 28.7% (6932 of 24161 functions)
  • lines: 47.2% (42564 of 90170 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
fad9be4 at 2024-03-04T09:44:44.253Z :recycle:

Please sign in to comment.