ci(fix): Use OIDC auth to login on ECR #10055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayandin
reviewed
Dec 9, 2024
bayandin
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
LGTM if it works 😄
We also have a bunch of AWS_ACCESS_KEY_DEV usage in other workflows:
.github/workflows/_build-and-test-locally.yml: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_DEV }}
.github/workflows/cloud-regress.yml: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_DEV }}
.github/workflows/neon_extra_builds.yml: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_DEV }}
.github/workflows/periodic_pagebench.yml: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_DEV }}
.github/workflows/pg-clients.yml: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_DEV }}
.github/workflows/pin-build-tools-image.yml: username: ${{ secrets.AWS_ACCESS_KEY_DEV }}
No tests were run or test report is not availableTest coverage report is not availableThe comment gets automatically updated with the latest test results
00900ca at 2024-12-09T12:05:51.289Z :recycle: |
rahulinux
force-pushed
the
ci/use-oidc-auth
branch
from
2c21bbf to
a43e2c2
Compare
sure, will update those as well. might need to create follow-up if something breaks. |
rahulinux
force-pushed
the
ci/use-oidc-auth
branch
15 times, most recently
from
998d6ea to
000081f
Compare
rahulinux
force-pushed
the
ci/use-oidc-auth
branch
from
cdd7e62 to
3d4cffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CI currently uses static credentials in some places. These are less secure and hard to maintain, so we are going to deprecate them and use OIDC auth.
Summary of changes