Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: azure: support batched deletions #10065

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: azure: support batched deletions #10065

wants to merge 1 commit into from

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Dec 9, 2024

Uses a patched branch of the Azure SDK that adds blob_batch support.

The test_azure::delete_prefix test is failing, otherwise all azure unit tests of remote_storage work.

TODO:

  • parse and validate response headers: the subrequests can fail individually, we need to fail the entire operation if even one fails. Right now we just return success if we got a result for the envelope operation.
  • maybe unify BlobBatchOperations and TransactionOperations to OdataBatch or something. which crate should it live in??
  • tests to ensure we can delete up to the limit many keys

cc #7931

@arpad-m arpad-m requested a review from a team as a code owner December 9, 2024 23:39
@arpad-m arpad-m requested a review from VladLazar December 9, 2024 23:39
Copy link

github-actions bot commented Dec 9, 2024

No tests were run or test report is not available

Test coverage report is not available

The comment gets automatically updated with the latest test results
229157e at 2024-12-09T23:58:59.326Z :recycle:

@arpad-m arpad-m marked this pull request as draft December 10, 2024 11:34
@arpad-m arpad-m mentioned this pull request Dec 10, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant