Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute_ctl: don't panic if control plane can't be reached #10078

Merged
merged 1 commit into from
Dec 11, 2024
Merged

compute_ctl: don't panic if control plane can't be reached #10078

merged 1 commit into from
Dec 11, 2024

Conversation

myrrc
Copy link
Contributor

@myrrc myrrc commented Dec 10, 2024 •
edited
Loading

Problem

If the control plane cannot be reached for some reason, compute_ctl panics

Summary of changes

panic is removed in favour of returning an error.
Code is reformatted a bit for more flat control flow

Resolves: #5391

@myrrc myrrc requested a review from a team as a code owner December 10, 2024 20:46
@myrrc myrrc requested a review from lubennikovaav December 10, 2024 20:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

7099 tests run: 6784 passed, 0 failed, 315 skipped (full report)

Flaky tests (5)

Postgres 17

Postgres 15

  • test_pgdata_import_smoke[None-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64
  • test_pgdata_import_smoke[8-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64

Postgres 14

Code coverage* (full report)

  • functions: 31.4% (8331 of 26537 functions)
  • lines: 47.7% (65614 of 137570 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
f511f24 at 2024-12-11T11:35:14.591Z :recycle:

lubennikovaav
lubennikovaav approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@lubennikovaav lubennikovaav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@myrrc myrrc added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit c79c1dd Dec 11, 2024
85 checks passed
@myrrc myrrc deleted the 5391/compute-ctl-panic branch December 11, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubennikovaav lubennikovaav lubennikovaav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compute_ctl panics if the control plane cannot be reached
2 participants
@myrrc @lubennikovaav