Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute: Add spec support for disabling LFC resizing #10132

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sharnoff
Copy link
Member

ref neondatabase/cloud#21731

Problem

When we manually override the LFC size for particular computes, autoscaling will typically undo that because vm-monitor will resize LFC itself.

So, we'd like a way to make vm-monitor not set LFC size — this actually already exists, if we just don't give vm-monitor a postgres connection string.

Summary of changes

Add a new field to the compute spec, disable_lfc_resizing. When set to true, we pass in None for its postgres connection string. That matches the configuration tested in neondatabase/autoscaling CI.

@sharnoff sharnoff requested review from a team and mikhail-sakhnov and removed request for a team December 12, 2024 23:40
@sharnoff sharnoff requested review from a team as code owners December 12, 2024 23:40
Copy link

github-actions bot commented Dec 13, 2024

7121 tests run: 6824 passed, 0 failed, 297 skipped (full report)


Flaky tests (4)

Postgres 17

Postgres 14

  • test_pgdata_import_smoke[None-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64

Code coverage* (full report)

  • functions: 31.4% (8401 of 26732 functions)
  • lines: 48.1% (66630 of 138656 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
0229962 at 2024-12-13T02:14:54.544Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants