Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: always require aws-oicd-role-arn input to be set #10145

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Dec 13, 2024

Problem

benchmarking job fails because aws-oicd-role-arn input is not set

Summary of changes:

  • Set aws-oicd-role-arn for `benchmarking job
  • Always require aws-oicd-role-arn to be set
  • Rename aws_oicd_role_arn to aws-oicd-role-arn for consistency

@bayandin bayandin requested a review from a team as a code owner December 13, 2024 16:18
@bayandin bayandin force-pushed the bayandin/always-require-aws-oicd-role-arn branch from ef34d33 to a052512 Compare December 13, 2024 16:27
@bayandin bayandin requested a review from rahulinux December 13, 2024 16:28
@bayandin bayandin changed the title CI: always require aws-oicd-role-arn inpute to be set CI: always require aws-oicd-role-arn input to be set Dec 13, 2024
Copy link

github-actions bot commented Dec 13, 2024

7095 tests run: 6798 passed, 0 failed, 297 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 31.4% (8397 of 26778 functions)
  • lines: 48.0% (66620 of 138651 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
4dff20a at 2024-12-13T19:33:31.664Z :recycle:

@bayandin bayandin added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit d56fea6 Dec 13, 2024
91 checks passed
@bayandin bayandin deleted the bayandin/always-require-aws-oicd-role-arn branch December 13, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants