[proxy]: Use TLS for cancellation queries #10152
Merged
+63
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7147 tests run: 6848 passed, 0 failed, 299 skipped (full report)Flaky tests (7)Postgres 17
Postgres 16
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
a60791c at 2024-12-17T19:34:58.284Z :recycle: |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
## Problem While reviewing #10152 I found it tricky to actually determine whether the connection used `allow_self_signed_compute` or not. I've tried to remove this setting in the past: * #7884 * #7437 * neondatabase/cloud#13702 But each time it seems it is used by e2e tests ## Summary of changes The `node_info.allow_self_signed_computes` is always initialised to false, and then sometimes inherits the proxy config value. There's no need this needs to be in the node_info, so removing it and propagating it via `TcpMechansim` is simpler.
awarus
force-pushed
the
cancel_tls
branch
2 times, most recently
from
7962721 to
ee62b24
Compare
pg_sni_router assumes that all the streams are upgradable to TLS. Cancellation requests were declined because of using NoTls config. Provide TLS client config for cancellation requests. Fixes #21789
conradludgate
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
pg_sni_router assumes that all the streams are upgradable to TLS. Cancellation requests were declined because of using NoTls config.
Summary of changes
Provide TLS client config for cancellation requests.
Fixes #21789