Add safekeeper membership conf to control file.

[arssher]

Problem

#9965

Summary of changes

Add safekeeper membership configuration struct itself and storing it in the control file. In passing also add creation timestamp to the control file (there were cases where I wanted it in the past).

Remove obsolete unused PersistedPeerInfo struct.

Remove the binary representation of cfile in the roundtrip test. Updating it is annoying, and we still test the actual roundtrip.

[github-actions]

7095 tests run: 6753 passed, 44 failed, 298 skipped (full report)

---

Failures on Postgres 17

• test_s3_wal_replay: release-x86-64, release-x86-64, release-arm64, release-arm64, debug-x86-64
• test_pull_timeline_while_evicted: release-x86-64, release-x86-64, release-arm64, release-arm64, debug-x86-64
• test_s3_eviction[0.0-True]: release-x86-64, release-x86-64, release-arm64, release-arm64, debug-x86-64
• test_s3_eviction[0.2-True]: release-x86-64, release-x86-64, release-arm64, release-arm64, debug-x86-64

Failures on Postgres 16

• test_s3_wal_replay: release-x86-64, release-arm64
• test_pull_timeline_while_evicted: release-x86-64, release-arm64
• test_s3_eviction[0.0-True]: release-x86-64, release-arm64
• test_s3_eviction[0.2-True]: release-x86-64, release-arm64

Failures on Postgres 15

• test_s3_wal_replay: release-x86-64, release-arm64
• test_pull_timeline_while_evicted: release-x86-64, release-arm64
• test_s3_eviction[0.0-True]: release-x86-64, release-arm64
• test_s3_eviction[0.2-True]: release-x86-64, release-arm64

Failures on Postgres 14

• test_s3_wal_replay: release-x86-64, release-arm64
• test_pull_timeline_while_evicted: release-x86-64, release-arm64
• test_s3_eviction[0.0-True]: release-x86-64, release-arm64
• test_s3_eviction[0.2-True]: release-x86-64, release-arm64

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_s3_wal_replay[release-pg14] or test_s3_wal_replay[release-pg14] or test_pull_timeline_while_evicted[release-pg14] or test_pull_timeline_while_evicted[release-pg14] or test_s3_eviction[release-pg14-0.0-True] or test_s3_eviction[release-pg14-0.0-True] or test_s3_eviction[release-pg14-0.2-True] or test_s3_eviction[release-pg14-0.2-True] or test_s3_wal_replay[release-pg15] or test_s3_wal_replay[release-pg15] or test_pull_timeline_while_evicted[release-pg15] or test_pull_timeline_while_evicted[release-pg15] or test_s3_eviction[release-pg15-0.0-True] or test_s3_eviction[release-pg15-0.0-True] or test_s3_eviction[release-pg15-0.2-True] or test_s3_eviction[release-pg15-0.2-True] or test_s3_wal_replay[release-pg16] or test_s3_wal_replay[release-pg16] or test_pull_timeline_while_evicted[release-pg16] or test_pull_timeline_while_evicted[release-pg16] or test_s3_eviction[release-pg16-0.0-True] or test_s3_eviction[release-pg16-0.0-True] or test_s3_eviction[release-pg16-0.2-True] or test_s3_eviction[release-pg16-0.2-True] or test_s3_wal_replay[release-pg17] or test_s3_wal_replay[release-pg17] or test_s3_wal_replay[release-pg17] or test_s3_wal_replay[release-pg17] or test_s3_wal_replay[debug-pg17] or test_pull_timeline_while_evicted[release-pg17] or test_pull_timeline_while_evicted[release-pg17] or test_pull_timeline_while_evicted[release-pg17] or test_pull_timeline_while_evicted[release-pg17] or test_pull_timeline_while_evicted[debug-pg17] or test_s3_eviction[release-pg17-0.0-True] or test_s3_eviction[release-pg17-0.0-True] or test_s3_eviction[release-pg17-0.0-True] or test_s3_eviction[release-pg17-0.0-True] or test_s3_eviction[debug-pg17-0.0-True] or test_s3_eviction[release-pg17-0.2-True] or test_s3_eviction[release-pg17-0.2-True] or test_s3_eviction[release-pg17-0.2-True] or test_s3_eviction[release-pg17-0.2-True] or test_s3_eviction[debug-pg17-0.2-True]"

Flaky tests (6)

Postgres 15

• test_compute_pageserver_connection_stress: release-arm64
• test_pgdata_import_smoke[None-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64
• test_tenant_detach_smoke: release-arm64

Postgres 14

• test_pgdata_import_smoke[None-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64
• test_pgdata_import_smoke[8-1024-RelBlockSize.MULTIPLE_RELATION_SEGMENTS]: release-arm64
• test_emergency_mode: release-arm64

Test coverage report is not available

_{The comment gets automatically updated with the latest test results
8b7de61 at 2024-12-19T09:56:10.147Z :recycle:}