safekeeper: lift benchmarking utils into safekeeper crate #10200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The benchmarking utilities are also useful for testing. We want to write tests in the safekeeper crate, so this commit lifts the utils to the safekeeper crate. They are compiled if the benchmarking features is enabled or if in test mode. A small extension is also included to allow generating wal from a given LSN. Safekeeper considers Lsn(0) invalid since it doesn't have initdb wal.
VladLazar
requested review from
tristan957,
arssher and
erikgrinaker
and removed request for
arssher
erikgrinaker
approved these changes
Dec 19, 2024
7095 tests run: 6796 passed, 0 failed, 299 skipped (full report)Flaky tests (3)Postgres 17
Postgres 16
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
8d153c5 at 2024-12-19T13:13:09.409Z :recycle: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The benchmarking utilities are also useful for testing. We want to write tests in the safekeeper crate.
Summary of changes
This commit lifts the utils to the safekeeper crate. They are compiled if the benchmarking features is enabled or if in test mode.