safekeeper: short-circuit interpreted wal sender #10202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may currently send a batch even if it hasn't decoded a new record. Pageserver treats this as a no-op. Once this merges and releases, the `InterpretedWalRecords` struct can be updated to remove the Option wrapper for `next_record_lsn`.
7095 tests run: 6797 passed, 0 failed, 298 skipped (full report)Flaky tests (1)Postgres 16
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
4047087 at 2024-12-19T13:18:46.744Z :recycle: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Safekeeper may currently send a batch to the pageserver even if it hasn't decoded a new record.
I think this is quite unlikely in the field, but worth adressing.
Summary of changes
Don't send anything if we haven't decoded a full record. Once this merges and releases, the
InterpretedWalRecordsstruct can be updated to remove the Option wrapper fornext_record_lsn.