Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default stotrage controller heartbeat interval from 100msec … #10206

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

knizhnik
Copy link
Contributor

Problem

Currently default value of storage controller heartbeat interval is 100msec. It means that 10 times per second it establish connection to PS. And it seems to be quite expensive.
At MacOS right now storage_controller consumes 70% CPU and trusts - 30%. So together they completely utilize one core.
A lot of us has Macs. Let's save environment a little bit and do not waste electricity and contribute to global warming.

By the way, on prod we have interval 10seconds

Summary of changes

Increase heartbeat interval from 100msec to 1 second.

Copy link

7095 tests run: 6798 passed, 0 failed, 297 skipped (full report)


Flaky tests (2)

Postgres 17

  • test_delete_timeline_exercise_crash_safety_failpoints[Check.RETRY_WITHOUT_RESTART-timeline-delete-after-rm]: release-arm64
  • test_timeline_copy[500000]: release-x86-64

Code coverage* (full report)

  • functions: 31.2% (8397 of 26876 functions)
  • lines: 47.9% (66643 of 139015 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
71d97c4 at 2024-12-19T16:50:28.744Z :recycle:

@knizhnik knizhnik added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 197a89a Dec 19, 2024
84 checks passed
@knizhnik knizhnik deleted the increase_default_heartbeat branch December 19, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants