Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libs/proxy: Add missing waker wake in poll_shutdown #10207

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cloneable
Copy link
Contributor

Problem

poll_shutdown() returns Poll::Pending but does not trigger a wake and callers seems to rely on this.

Summary of changes

Add a wake_by_ref().

@cloneable cloneable requested a review from a team as a code owner December 19, 2024 16:16
@conradludgate
Copy link
Contributor

https://github.com/neondatabase/rust-postgres/blob/00940fcdb57a8e99e805297b75839e7c4c7b1796/tokio-postgres/src/connection.rs#L300 would be good to check if upstream tokio-postgres still has this same issue

@conradludgate
Copy link
Contributor

On second look, this might be correct before. poll_read/poll_write will wake when ready.

@cloneable
Copy link
Contributor Author

@cloneable
Copy link
Contributor Author

We can look at this once you're back. I'll mark this PR as draft until we know more.

@cloneable cloneable marked this pull request as draft December 19, 2024 16:42
Copy link

7095 tests run: 6796 passed, 0 failed, 299 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 16

  • test_physical_replication_config_mismatch_max_locks_per_transaction: release-arm64

Postgres 15

  • test_physical_replication_config_mismatch_max_locks_per_transaction: release-x86-64

Code coverage* (full report)

  • functions: 31.2% (8397 of 26876 functions)
  • lines: 48.0% (66660 of 139016 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
33166ea at 2024-12-19T17:14:40.294Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants