Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): report timestamp is in the past if the key is missing #10210

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Dec 19, 2024

Problem

If for some reasons we already garbage-collected the data under an LSN but the caller uses a past LSN for the find_time_cutoff function, now we will report a missing key error and GC will never proceed.

Note that missing key error can also happen if the key is really missing (i.e., during the past offload incidents)

Summary of changes

Make sure GC proceeds by bumping the LSN. However, data within the configured PiTR might not be accessible.

Copy link

7095 tests run: 6798 passed, 0 failed, 297 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 16

Postgres 14

  • test_physical_replication_config_mismatch_max_locks_per_transaction: release-x86-64

Code coverage* (full report)

  • functions: 31.2% (8398 of 26876 functions)
  • lines: 47.9% (66647 of 139020 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
1ae01d8 at 2024-12-19T19:02:21.319Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant