-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dump more info in layer map #4567
Conversation
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
1016 tests run: 973 passed, 0 failed, 43 skipped (full report)The comment gets automatically updated with the latest test results
f2f327f at 2023-07-06T14:47:33.696Z :recycle: |
Why not to shrink the key range instead? Or incremental layer can contain images from entire key range? |
Incremental layer contains part of the keys from an entire key range. Previously, we will scan all keys within the range to construct the layer so that we don't need to search more once we hit the image layer. However, it is costly to construct such image layers, because we need to scan every key in the range. Therefore, with incremental image layer, an image layer can only contain some keys within the key range, and we can decide whether to generate an image for a key based on some heuristics. |
…h/partial-image-layer
Signed-off-by: Alex Chi <[email protected]>
this might cause we miss the delta records == image_lsn, converting to draft. |
Signed-off-by: Alex Chi Z <[email protected]>
The true implementation for incremental layer is more complex than I thought and therefore I excluded it from this PR. Now we only have the dump more info thing in this PR and appreciate an easy approval from someone :) |
Signed-off-by: Alex Chi Z <[email protected]>
…h/partial-image-layer
81d00e9
to
f2f327f
Compare
Problem
A simple commit extracted from #4539
Summary of changes
This PR adds more info for layer dumps (is_delta, is_incremental, size).
Checklist before requesting a review
Checklist before merging