-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy: use postgres_protocol scram/sasl code #4748
Conversation
2442 tests run: 2323 passed, 0 failed, 119 skipped (full report)Flaky tests (3)Postgres 16Code coverage (full report)
The comment gets automatically updated with the latest test results
8e5f15f at 2024-02-18T22:59:39.466Z :recycle: |
Edit: Reading again, it seems that there have only been testing changes. I think this PR is fine but to make sure one should make |
What do you mean? postgres-protocol is a fully Rust library and we already indirectly depend on it through tokio-postgres. You can verify this given the tiny change to the Cargo.lock. Infact, we even have our own fork of postgres-protocol
I have direct plans to use postgres-protocol further soon (i plan on removing some uses of tokio-postgres), so I see no point to this |
Oh it is indeed, my concern is moot then. I'm still getting familiar to everything, I apologize.
fair |
11fd596
to
f6dd2aa
Compare
3dfb69c
to
c41bc82
Compare
c41bc82
to
8e5f15f
Compare
scram::password
was used in tests only. can be replaced withpostgres_protocol::password
.postgres_protocol::authentication::sasl
provides a client impl of SASL which improves our ability to testChecklist before requesting a review
Checklist before merging