Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename EphmeralFile::size to EphemeralFile::len #5076

Merged
merged 1 commit into from
Aug 24, 2023
Merged

rename EphmeralFile::size to EphemeralFile::len #5076

merged 1 commit into from
Aug 24, 2023

Conversation

Reminiscent
Copy link
Contributor

Problem

close #5034

Summary of changes

Based on the comment. Just rename the EphmeralFile::size to EphemeralFile::len.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@Reminiscent Reminiscent requested review from a team as code owners August 23, 2023 09:52
@Reminiscent Reminiscent requested review from lubennikovaav and problame and removed request for a team August 23, 2023 09:52
arpad-m
arpad-m approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@arpad-m arpad-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@arpad-m arpad-m mentioned this pull request Aug 23, 2023
Closed
@Reminiscent
Copy link
Contributor Author

@arpad-m Hi, I see the neon-cloud-e2e test has failed. But I can't see the content of the test. So how can I to fix this problem?

@problame
Copy link
Contributor

It's part of a not-yet-public CI pipeline for regression tests with the control plane.

The CI pipeline had operational issues in the period where your run happened.

I've triggered a re-run.

@arpad-m arpad-m merged commit fa74d56 into neondatabase:main Aug 24, 2023
@Reminiscent Reminiscent deleted the issue5034 branch August 24, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpad-m arpad-m arpad-m approved these changes

@lubennikovaav lubennikovaav Awaiting requested review from lubennikovaav lubennikovaav was automatically assigned from neondatabase/compute

@problame problame Awaiting requested review from problame problame is a code owner automatically assigned from neondatabase/storage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename EphmeralFile::size to EphemeralFile::len
3 participants
@Reminiscent @problame @arpad-m