Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: update for libicu dependency #5343

Merged
merged 1 commit into from
Sep 21, 2023
Merged

README: update for libicu dependency #5343

merged 1 commit into from
Sep 21, 2023

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Sep 20, 2023

Problem

In 83e7e5d dependencies were only updated for Mac users. Without libicu, postgres 16 build fails.

Summary of changes

Update dependencies on Ubuntu and fedora to include libicu.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added t/bug Issue Type: Bug a/documentation Area: related to documentation labels Sep 20, 2023
@github-actions
Copy link

2496 tests run: 2380 passed, 0 failed, 116 skipped (full report)


Flaky tests (4)

Postgres 16

  • test_partial_evict_tenant: debug
  • test_get_tenant_size_with_multiple_branches: debug
  • test_wal_lagging: release

Postgres 14

  • test_get_tenant_size_with_multiple_branches: debug

Code coverage (full report)

  • functions: 53.0% (7796 of 14702 functions)
  • lines: 81.1% (45443 of 56019 lines)

The comment gets automatically updated with the latest test results
e067329 at 2023-09-20T16:05:44.218Z :recycle:

@jcsp jcsp marked this pull request as ready for review September 21, 2023 06:47
@jcsp jcsp requested review from bayandin and arpad-m September 21, 2023 06:47
@arpad-m
Copy link
Member

arpad-m commented Sep 21, 2023

I did not have to install libicu, but it is installed on my system for some reason. Could not find the package in history.log to find when I installed it.

@arpad-m arpad-m merged commit 97a5710 into main Sep 21, 2023
37 checks passed
@arpad-m arpad-m deleted the jcsp/readme-libicu branch September 21, 2023 08:28
@arpad-m
Copy link
Member

arpad-m commented Sep 21, 2023

Merged by myself because of hardware issue for @jcsp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/documentation Area: related to documentation t/bug Issue Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants