vm-monitor: Replace filter_map with filter #5443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think there's a clippy lint for this? Not sure if we're not using that, or something. In any case, I was confused reading this code previously, and I think this change should make what's going on a bit clearer (because `high` wasn't changing anyways!).
2232 tests run: 2116 passed, 0 failed, 116 skipped (full report)Code coverage (full report)
The comment gets automatically updated with the latest test results
8e1c994 at 2023-10-03T03:58:32.462Z :recycle: |
koivunej
approved these changes
Oct 31, 2023
|
ah dang, this is no longer relevant since #5524 - forgot to close |
auto-merge was automatically disabled
October 31, 2023 19:18
Pull request was closed
sharnoff
deleted the
sharnoff/vm-monitor-replace-filter_map-with-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's a clippy lint for this? Not sure if we're not using that, or something.
In any case, I was confused reading this code previously, and I think this change should make what's going on a bit clearer (because
highwasn't changing anyways!).