Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: deny async-std and friends #5849

Merged
merged 3 commits into from
Nov 10, 2023
Merged

build: deny async-std and friends #5849

merged 3 commits into from
Nov 10, 2023

Conversation

koivunej
Copy link
Member

rationale: some crates pull these in as default; hopefully these hints will require less cleanup-after and Cargo.lock file watching.

follow-up to #5848.

rationale: some crates pull these in as default; hopefully these hints
will require less cleanup-after and Cargo.lock file watching.
@koivunej koivunej requested a review from arpad-m November 10, 2023 14:06
@koivunej
Copy link
Member Author

koivunej commented Nov 10, 2023

I failed to check (or parse the 5k line output): https://github.com/neondatabase/neon/actions/runs/6825817145/job/18564454476#step:11:63

error[banned]: crate 'async-channel = 1.9.0' is explicitly banned

I could set the --hide-inclusion-graph so the output would be readable. Trying that before removing the async-{channel,lock} deny.

After --hide-inclusion-graph: https://github.com/neondatabase/neon/actions/runs/6826007887/job/18565016413?pr=5849

Copy link

2376 tests run: 2258 passed, 0 failed, 118 skipped (full report)


Flaky tests (3)

Postgres 16

  • test_competing_branchings_from_loading_race_to_ok_or_err: debug
  • test_ondemand_download_timetravel[local_fs]: debug

Postgres 15

Code coverage (full report)

  • functions: 54.7% (8926 of 16330 functions)
  • lines: 81.5% (51326 of 62999 lines)

The comment gets automatically updated with the latest test results
a50222d at 2023-11-10T15:15:13.356Z :recycle:

@koivunej koivunej enabled auto-merge (squash) November 10, 2023 16:09
@koivunej koivunej merged commit b7f4520 into main Nov 10, 2023
38 checks passed
@koivunej koivunej deleted the deny_asyncstd branch November 10, 2023 17:02
jcsp pushed a commit that referenced this pull request Nov 14, 2023
rationale: some crates pull these in as default; hopefully these hints
will require less cleanup-after and Cargo.lock file watching.

follow-up to #5848.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants