Add build_info_metric with git_version and build_tag for compute_ctl #5961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubennikovaav
requested review from
mtyazici and
bojanserafimov
and removed request for
a team
2394 tests run: 2299 passed, 0 failed, 95 skipped (full report)Code coverage (full report)
The comment gets automatically updated with the latest test results
a769a43 at 2023-11-28T18:48:49.419Z :recycle: |
vadim2404
reviewed
Nov 28, 2023
| @@ -51,6 +52,20 @@ async fn routes(req: Request<Body>, compute: &Arc<ComputeNode>) -> Response<Body | |||
| Response::new(Body::from(serde_json::to_string(&status_response).unwrap())) | |||
| } | |||
|
|
|||
| // prometheus metrics | |||
| (&Method::GET, "/metrics") => { | |||
There was a problem hiding this comment.
do you expect to scrape these metrics by Prometheus?
There was a problem hiding this comment.
yes, that's the plan
|
I found that we already have build_tag information in console db, so no need to expose this as a metric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be very convenient to have this information in grafana to check which versions of compute are active right now.