Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TEST_OUTPUT envvar in pageserver #5984

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

bojanserafimov
Copy link
Contributor

In python tests we can use TEST_OUTPUT envvar to overwrite the default dir. It's useful for perf tests where you want to write to a dir inside the mounted ssd (the neon repo itself might not be). I'm sure there are other workarounds but this seems generally useful anyway.

@bojanserafimov bojanserafimov added c/storage/pageserver Component: storage: pageserver a/test Area: related to testing a/benchmark Area: related to benchmarking labels Nov 29, 2023
@bojanserafimov bojanserafimov requested a review from a team as a code owner November 29, 2023 20:30
@bojanserafimov bojanserafimov requested review from problame and removed request for a team November 29, 2023 20:30
Copy link

2406 tests run: 2310 passed, 0 failed, 96 skipped (full report)


Flaky tests (3)

Postgres 16

  • test_emergency_relocate_with_branches_slow_replay[local_fs]: debug

Postgres 15

  • test_gc_cutoff: debug
  • test_ondemand_download_timetravel[mock_s3]: debug

Code coverage (full report)

  • functions: 54.5% (9179 of 16846 functions)
  • lines: 82.1% (53503 of 65166 lines)

The comment gets automatically updated with the latest test results
bea0b13 at 2023-11-29T21:08:42.924Z :recycle:

@problame problame requested a review from bayandin November 30, 2023 10:51
Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer if we add an intermediary component like $TEST_OUTPUT_DIR/pageserver_rust_tests/test_{test_name}

@bojanserafimov bojanserafimov merged commit fd81945 into main Dec 1, 2023
44 checks passed
@bojanserafimov bojanserafimov deleted the ps-test-output-dir branch December 1, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/benchmark Area: related to benchmarking a/test Area: related to testing c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants