-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for migrations within compute_ctl #6085
Conversation
2268 tests run: 2184 passed, 0 failed, 84 skipped (full report)Code coverage (full report)
The comment gets automatically updated with the latest test results
d2e0d23 at 2024-01-18T22:13:04.545Z :recycle: |
eff9d16
to
458c554
Compare
@kelvich , you wanted to review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good generally. I'd change migration tracking to be a bit more robust
8f9bbc2
to
120edb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is in a good state right now.
wonder if there is an easy way to feature-flag this and gradually roll it out. or at least region by region.
cc @ololobus to be aware = ) |
also tests are broken |
See for compute feature flags
I'm going to get use of them in #6008 |
986d092
to
948e954
Compare
948e954
to
d2e0d23
Compare
Added support for these feature flags in https://github.com/neondatabase/cloud/pull/9450, will merge this PR once that one finishes |
Problem
It's easy bungle stuff with regards to permissions or other stuff. Fixing it is hard because we don't have a way to run a query on everyone's computes exactly once. Any migrations we currently do makes it so that we have to maek sure everything is ok to be run many times.
Summary of changes
Executes migrations on startup and persists the migrations inside of a table with a single row.
Checklist before requesting a review
Checklist before merging