Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better Json parsing errors #6135

Merged
merged 2 commits into from
Dec 15, 2023
Merged

fix: better Json parsing errors #6135

merged 2 commits into from
Dec 15, 2023

Conversation

koivunej
Copy link
Member

Before any json parsing from the http api only returned errors were per field errors. Now they are done using serde_path_to_error, which at least helped greatly with the disk_usage_eviction_run used for testing. I don't think this can conflict with anything added in #5310.

@koivunej koivunej requested a review from a team as a code owner December 13, 2023 23:38
@koivunej koivunej requested review from problame and removed request for a team December 13, 2023 23:38
Copy link

2184 tests run: 2098 passed, 0 failed, 86 skipped (full report)


Flaky tests (3)

Postgres 16

  • test_crafted_wal_end[last_wal_record_crossing_segment]: release
  • test_pitr_gc: debug

Postgres 15

  • test_statvfs_pressure_usage: debug

Code coverage (full report)

  • functions: 55.2% (9457 of 17136 functions)
  • lines: 82.3% (54654 of 66416 lines)

The comment gets automatically updated with the latest test results
5cb72df at 2023-12-14T00:14:21.838Z :recycle:

Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, didn't know this crate existed.

Didn't vet it as part of this review, though.

@koivunej
Copy link
Member Author

Nice, didn't know this crate existed.

Didn't vet it as part of this review, though.

It is not a new dependency for us since some earlier PR.

@koivunej koivunej enabled auto-merge (squash) December 15, 2023 10:18
@koivunej koivunej merged commit 07508fb into main Dec 15, 2023
41 checks passed
@koivunej koivunej deleted the json_parsing_fixes branch December 15, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants