refactor(walredo): use heavier_once_cell to store the process handle #6595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_cell The API is nice, exactly what we want, but we would want a more optimistic underlying sync primitive.
… problame/2024-02-walredo-work/prespawn/broken-tenants-no-walredo
…o-walredo' into problame/2024-02-walredo-work/prespawn/heaver-once-cell-for-process-launch
…vier_once_cell" This reverts commit 2ab2608.
This reverts commit e8f1af5.
…with heavier_once_cell"" This reverts commit 6d94d9f.
Using the RwLock reduces contention on the hot path.
… problame/2024-02-walredo-work/prespawn/broken-tenants-no-walredo
…o-walredo' into problame/2024-02-walredo-work/prespawn/heaver-once-cell-for-process-launch
This reverts commit 20e8262.
… problame/2024-02-walredo-work/prespawn/broken-tenants-no-walredo
…o-walredo' into problame/2024-02-walredo-work/prespawn/heaver-once-cell-for-process-launch
…-for-process-launch' into problame/2024-02-walredo-work/prespawn/switch-to-heavier-once-cell-with-rwlock
problame
changed the title
2388 tests run: 2274 passed, 0 failed, 114 skipped (full report)Flaky tests (2)Postgres 15
Postgres 14
Code coverage (full report)
The comment gets automatically updated with the latest test results
3ec02d1 at 2024-02-06T17:35:17.693Z :recycle: |
Base automatically changed from
problame/2024-02-walredo-work/prespawn/heaver-once-cell-for-process-launch
to
main
February 6, 2024 12:04
…h-to-heavier-once-cell-with-rwlock
|
This should be ready for merge |
…edo-work/prespawn/switch-to-heavier-once-cell-with-rwlock
…h-to-heavier-once-cell-with-rwlock
|
Yes, I still need something like this. If we can't make tokio::sync::RwLock-based heavier_once_cell work, I'll use a tokio::sync::RwLock myself in this PR. |
|
Note this PR is part of #6581 which is currently on hold due to other priorities. |
|
this is stale and not directly applicable because we had to revert the heavier_once_cell changes: #6704 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preceding PR #6589 we made
heavier_once_celluse an RwLock, so, now we can switch walredo to use it without introducing a performance regression.I want to switch to
heavier_once_cellbecause we'll replace theWalRedoProcess::launch()call with anasync fncall when we switch to a pre-spawned pool of walredo processes in PR #6596 .part of #6581