-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy: send cancel notifications to all instances #6719
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2436 tests run: 2318 passed, 0 failed, 118 skipped (full report)Flaky tests (2)Postgres 16
Postgres 14
Code coverage (full report)
The comment gets automatically updated with the latest test results
d913971 at 2024-02-13T11:36:52.862Z :recycle: |
…base/neon into proxy-send-cancel-notifications
conradludgate
approved these changes
Feb 13, 2024
conradludgate
pushed a commit
that referenced
this pull request
Feb 14, 2024
## Problem If cancel request ends up on the wrong proxy instance, it doesn't take an effect. ## Summary of changes Send redis notifications to all proxy pods about the cancel request. Related issue: #5839, neondatabase/cloud#10262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If cancel request ends up on the wrong proxy instance, it doesn't take an effect.
Summary of changes
Send redis notifications to all proxy pods about the cancel request.
Related issue: #5839, https://github.com/neondatabase/cloud/issues/10262
Checklist before requesting a review
Checklist before merging