Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy: send cancel notifications to all instances #6719

Merged
merged 14 commits into from
Feb 13, 2024

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Feb 11, 2024

Problem

If cancel request ends up on the wrong proxy instance, it doesn't take an effect.

Summary of changes

Send redis notifications to all proxy pods about the cancel request.

Related issue: #5839, https://github.com/neondatabase/cloud/issues/10262

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Feb 11, 2024

2436 tests run: 2318 passed, 0 failed, 118 skipped (full report)


Flaky tests (2)

Postgres 16

  • test_crafted_wal_end[last_wal_record_crossing_segment]: debug

Postgres 14

Code coverage (full report)

  • functions: 55.9% (12836 of 22945 functions)
  • lines: 82.5% (69218 of 83902 lines)

The comment gets automatically updated with the latest test results
d913971 at 2024-02-13T11:36:52.862Z :recycle:

@khanova khanova marked this pull request as ready for review February 12, 2024 11:13
@khanova khanova requested a review from a team as a code owner February 12, 2024 11:13
@khanova khanova requested review from conradludgate and removed request for a team February 12, 2024 11:13
Anna Khanova added 2 commits February 12, 2024 13:59
proxy/src/redis/notifications.rs Outdated Show resolved Hide resolved
proxy/src/cancellation.rs Outdated Show resolved Hide resolved
proxy/src/cancellation.rs Outdated Show resolved Hide resolved
@khanova khanova merged commit 331935d into main Feb 13, 2024
49 checks passed
@khanova khanova deleted the proxy-send-cancel-notifications branch February 13, 2024 16:58
conradludgate pushed a commit that referenced this pull request Feb 14, 2024
## Problem

If cancel request ends up on the wrong proxy instance, it doesn't take
an effect.

## Summary of changes

Send redis notifications to all proxy pods about the cancel request.

Related issue: #5839,
neondatabase/cloud#10262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants