Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: add more http logging #6726

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

conradludgate
Copy link
Contributor

@conradludgate conradludgate commented Feb 12, 2024

Problem

hard to see where time is taken during HTTP flow.

Summary of changes

add a lot more for query state. add a conn_id field to the sql-over-http span

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@conradludgate conradludgate marked this pull request as ready for review February 12, 2024 10:25
@conradludgate conradludgate requested a review from a team as a code owner February 12, 2024 10:25
@conradludgate conradludgate requested review from khanova and removed request for a team February 12, 2024 10:25
Copy link

github-actions bot commented Feb 12, 2024

2430 tests run: 2320 passed, 0 failed, 110 skipped (full report)


Flaky tests (4)

Postgres 16

  • test_compute_pageserver_connection_stress: debug
  • test_secondary_mode_eviction: release

Postgres 15

  • test_crafted_wal_end[last_wal_record_crossing_segment]: debug

Postgres 14

  • test_sharding_split_smoke: release

Code coverage (full report)

  • functions: 54.9% (11880 of 21625 functions)
  • lines: 82.1% (66281 of 80693 lines)

The comment gets automatically updated with the latest test results
bd6c68e at 2024-02-12T15:01:09.339Z :recycle:

@conradludgate conradludgate force-pushed the proxy-fix-http-observability branch from e9870c5 to bd6c68e Compare February 12, 2024 14:15
@conradludgate conradludgate enabled auto-merge (squash) February 12, 2024 14:16
@conradludgate conradludgate merged commit 789a71c into main Feb 12, 2024
49 checks passed
@conradludgate conradludgate deleted the proxy-fix-http-observability branch February 12, 2024 15:03
jcsp pushed a commit that referenced this pull request Feb 12, 2024
## Problem

hard to see where time is taken during HTTP flow.

## Summary of changes

add a lot more for query state. add a conn_id field to the sql-over-http
span
conradludgate added a commit that referenced this pull request Feb 14, 2024
## Problem

hard to see where time is taken during HTTP flow.

## Summary of changes

add a lot more for query state. add a conn_id field to the sql-over-http
span
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants