Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): pagebench doesn't work with released artifacts #6757

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

problame
Copy link
Contributor

The canonical release artifact of neon.git is the Docker image with all
the binaries in them:

docker pull neondatabase/neon:release-4854
docker create --name extract neondatabase/neon:release-4854
docker cp extract:/usr/local/bin/pageserver ./pageserver.release-4854
chmod +x pageserver.release-4854
cp -a pageserver.release-4854 ./target/release/pageserver

Before this PR, these artifacts didn't expose the keyspace API,
thereby preventing pagebench get-page-latest-lsn from working.

Having working pagebench is useful, e.g., for experiments in staging.
So, expose the API, but don't document it, as it's not part of the
interface with control plane.

The canonical release artifact of neon.git is the Docker image with all
the binaries in them:

```
docker pull neondatabase/neon:release-4854
docker create --name extract neondatabase/neon:release-4854
docker cp extract:/usr/local/bin/pageserver ./pageserver.release-4854
chmod +x pageserver.release-4854
cp -a pageserver.release-4854 ./target/release/pageserver
```

Before this PR, these artifacts didn't expose the `keyspace` API,
thereby preventing `pagebench get-page-latest-lsn` from working.

Having working pagebench is useful, e.g., for experiments in staging.
So, expose the API, but don't document it, as it's not part of the
interface with control plane.
@problame problame marked this pull request as ready for review February 14, 2024 15:30
@problame problame requested a review from a team as a code owner February 14, 2024 15:30
@problame problame requested review from koivunej and removed request for a team February 14, 2024 15:30
@problame problame enabled auto-merge (squash) February 14, 2024 15:30
Copy link

2436 tests run: 2317 passed, 0 failed, 119 skipped (full report)


Flaky tests (4)

Postgres 16

  • test_create_snapshot: debug
  • test_timeline_deletion_with_files_stuck_in_upload_queue: debug

Postgres 15

Code coverage (full report)

  • functions: 56.0% (12850 of 22964 functions)
  • lines: 82.6% (69346 of 83998 lines)

The comment gets automatically updated with the latest test results
050fb31 at 2024-02-14T16:34:49.743Z :recycle:

@problame problame merged commit 7d3cdc0 into main Feb 14, 2024
50 checks passed
@problame problame deleted the problame/expose-keyspace-api branch February 14, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants