Rename binary attachment_service -> storage_controller

[jcsp]

Problem

The storage controller binary still has its historic attachment_service name -- it will be painful to change this later because we can't atomically update this repo and the helm charts used to deploy.

Companion helm chart change: neondatabase/helm-charts#70

Summary of changes

• Change the name of the binary to storage_controller
• Skipping renaming things in the source right now: this is just to get rid of the legacy name in external interfaces.

Checklist before requesting a review

• I have performed a self-review of my code.
• If it is a core feature, I have added thorough tests.
• Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
• If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

• Do not forget to reformat commit message to not include the above checklist

[github-actions]

2490 tests run: 2369 passed, 0 failed, 121 skipped (full report)

---

Code coverage* (full report)

• functions: 28.8% (6993 of 24311 functions)
• lines: 47.3% (43012 of 90873 lines)

* collected from Rust tests only

---

_{The comment gets automatically updated with the latest test results
d84383e at 2024-03-07T13:34:03.114Z :recycle:}