Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pageserver): compute aux file size on initial logical size calculation #7958

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jun 4, 2024

Problem

close #7822
close #7443

Summary of changes

Aux file metrics is computed incrementally. If the size is not initialized, the metrics will never show up. This pull request adds the functionality to compute the aux file size on initial logical size calculation.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from arpad-m June 4, 2024 15:58
@skyzh skyzh requested a review from a team as a code owner June 4, 2024 15:58
Copy link

github-actions bot commented Jun 4, 2024

3186 tests run: 3047 passed, 0 failed, 139 skipped (full report)


Flaky tests (2)

Postgres 16

  • test_vm_bit_clear_on_heap_lock: debug

Postgres 14

Code coverage* (full report)

  • functions: 31.5% (6570 of 20885 functions)
  • lines: 48.4% (50828 of 105005 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
a2344b9 at 2024-06-04T16:53:06.999Z :recycle:

@skyzh skyzh merged commit 1a8d53a into main Jun 4, 2024
64 checks passed
@skyzh skyzh deleted the skyzh/initial-aux-size branch June 4, 2024 17:47
@arpad-m arpad-m mentioned this pull request Jun 4, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

initialize aux file size metrics on logical size initial calculation metrics for new aux file storage
2 participants