-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(pageserver): add test wal record for unit testing #8015
Conversation
Signed-off-by: Alex Chi Z <[email protected]>
3210 tests run: 3068 passed, 0 failed, 142 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
d20086c at 2024-06-12T17:30:54.411Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The clear
doesn't seem to be used in tests?
Also, have you thought about another field that controls whether the record is will_init
?
Approving since this is cfg(test)
only and easily changeable later.
that's true, will add more tests before merging |
There are some limitations with NeonWalRecords:
I added the variants for clear/init records but did not use them in the test cases because of the above limitation. Will have a separate pull request to discuss how to deal with it. Besides that, if there are no further comments, I will get this pull request merged tomorrow. |
Signed-off-by: Alex Chi Z <[email protected]>
34842ca
to
96b9a47
Compare
Signed-off-by: Alex Chi Z <[email protected]>
#8002 We need mock WAL record to make it easier to write unit tests. This pull request adds such a record. It has `clear` flag and `append` field. The tests for legacy-enhanced compaction are not modified yet and will be part of the next pull request. --------- Signed-off-by: Alex Chi Z <[email protected]>
Problem
#8002
Summary of changes
We need mock WAL record to make it easier to write unit tests. This pull request adds such a record. It has
clear
flag andappend
field. The tests for legacy-enhanced compaction are not modified yet and will be part of the next pull request.Checklist before requesting a review
Checklist before merging